feat: support BREAKING CHANGE #168
Conversation
src/getCommitMeaning.ts
Outdated
| const { notes, type } = conventionalCommitsParser.sync(message, { | ||
| // @ts-expect-error - options from https://github.com/conventional-changelog/conventional-changelog/issues/648#issuecomment-704867077 | ||
| breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/, | ||
| }); |
There was a problem hiding this comment.
[Refactor] No need for a // @ts-expect-error when an assertion can do:
| const { notes, type } = conventionalCommitsParser.sync(message, { | |
| // @ts-expect-error - options from https://github.com/conventional-changelog/conventional-changelog/issues/648#issuecomment-704867077 | |
| breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/, | |
| }); | |
| // options from https://github.com/conventional-changelog/conventional-changelog/issues/648#issuecomment-704867077 | |
| const { notes, type } = conventionalCommitsParser.sync(message, { | |
| breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/, | |
| } as object); |
This is actually a great opportunity to clean up the DefinitelyTyped types for conventional-commits-parser. Is that something you have time for too? No worries if not, I will if you don't. 🙂
There was a problem hiding this comment.
I'll try to deal with it. It’s always exciting to have the opportunity to work on an open source project.
JoshuaKGoldberg
added
the
status: waiting for author
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
github-actions
bot
removed
the
status: waiting for author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 63.55% 65.78% +2.23%
==========================================
Files 6 6
Lines 107 114 +7
Branches 12 15 +3
==========================================
+ Hits 68 75 +7
Misses 39 39 ☔ View full report in Codecov by Sentry. |
|
Note that the compliance PR action is failing because this PR is sent from https://github.com/hyoban/should-semantic-release/tree/main, rather than a separate branch. https://www.joshuakgoldberg.com/blog/contributing-to-a-create-typescript-app-repository-faqs/#how-do-i-reset-my-main-back-to-the-upstreams has some tips for dealing with that. Not a blocker, just a heads up. 🙂 |
|
@all-contributors please add @hyoban for code.
|
|
I've put up a pull request to add @hyoban! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
|
Thanks, I'll be careful next time. |
PR Checklist
trueforBREAKING CHANGE? #139status: accepting prsOverview
continue #140
related conventional-changelog/conventional-changelog#648